Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Specify GRUB2 kernel by default when deploying via Linode #574

Closed
wants to merge 11 commits into from

Conversation

rmcintosh
Copy link
Contributor

@rmcintosh rmcintosh commented Apr 4, 2017

This ties to ansible/ansible#23100 which was submitted to help ease the issues described in #500

The change makes the deployed instance use the GRUB2 Linode kernel option which now allows use of the distribution's supplied kernel, rather than the hypervisor's kernel.

I'm not intimately familiar with streisand so If I've missed the mark somewhere, please let me know.

This enables you to use the distribution's kernel rather than the kernel supplied by the hypervisor
@jlund
Copy link
Member

jlund commented Apr 6, 2017

This is fantastic! Thanks for making this happen.

We will need to wait until the kernel_id argument is in a released version of Ansible before we can merge this PR, but it looks like that will be happening soon. At that point we can change the required Ansible version here and :shipit:

@cpu cpu added the status/blocked/dep For items blocked on an external dependency (often Ansible) label Apr 8, 2017
@cpu
Copy link
Collaborator

cpu commented Apr 15, 2017

@zx2c4 I might be confused, but it looked like the relevant commit was in the 425 commits to devel after the tag. Did you find release notes for v.2.3.0.0-1 that mention the required commit?

@rmcintosh
Copy link
Contributor Author

rmcintosh commented Apr 15, 2017 via email

cpu pushed a commit that referenced this pull request Apr 16, 2017
Only in the next ansible version will we have support for setting
Linode's kernels directly from our playbooks. Until then, we need to
monkey patch around this limitation.

This should be reverted when #574 is merged.

Fixes: #500
Fixes: #609
@cpu
Copy link
Collaborator

cpu commented Apr 16, 2017

When this is merged we should also revert fc73677, the workaround from #609

@rmcintosh
Copy link
Contributor Author

rmcintosh commented Apr 17, 2017

@jlund for this (once the ansible change goes through), it seems like we should we just hardcode the kernelid as in #613, yeah?

@zx2c4
Copy link
Contributor

zx2c4 commented Apr 17, 2017

I think you have the right idea here. I've submitted a PR -- #623 -- for making the distro id more like how you do it in this PR.

@rmcintosh
Copy link
Contributor Author

fair enough, thanks @zx2c4! I'll match up after it's merged

@cpu
Copy link
Collaborator

cpu commented Sep 21, 2017

I think the Ansible release we were waiting for on this PR is out. Might be time to knock the cobwebs off and see if we can land this and retire a monkey patch :-)

@rmcintosh
Copy link
Contributor Author

nice - I will do that

thanks for the heads up!

@cpu cpu added area/provisioning area/wireguard kind/bug provider/linode and removed status/blocked/dep For items blocked on an external dependency (often Ansible) labels Sep 23, 2017
@cpu cpu added the status/revisions-needed For items with outstanding requested changes label Oct 10, 2017
@rmcintosh
Copy link
Contributor Author

the conflicts here are annoying to fix so I'm just going to re-PR this since it is not a large change

@cpu
Copy link
Collaborator

cpu commented Oct 16, 2017

Thanks for sticking with this one @rmcintosh :-) Nice to see a ticket from April 4th marked closed! 🎉 🎉 🎉

@rmcintosh rmcintosh deleted the patch-1 branch October 16, 2017 22:06
@rmcintosh
Copy link
Contributor Author

Happy to have helped! ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants