New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback URIs for getting public IP #1652

Closed

SpaceMonkeyy86 opened this issue Nov 17, 2021 · 1 comment · Fixed by #1663

Labels

Area: setup Type: bug

Contributor

SpaceMonkeyy86 commented Nov 17, 2021 •

edited by Measurity

Loading

Sometimes the request to https://ipv4bot.whatismyipaddress.com/ fails or returns an error, which produces this unhelpful message:

Could not get your external IP. You are on your own...

I propose that additional IP checking sites be supported in case this check fails. Some candidates are:

Collaborator

Measurity commented Nov 17, 2021

You can ask the router which external IP it has through UPnP. We should use this as the first option before falling back to sites.

Measurity added Area: setup Type: bug labels

Measurity linked a pull request

that will close this issue

Refactored UPnP and simplified IP messages #1663

Merged

2 tasks

Measurity closed this as completed in #1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment