Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 upgrade script: remoteTimeout is not added to custom remoteWrite section #1412

Closed
andrzej-stencel opened this issue Feb 11, 2021 · 1 comment · Fixed by #1467
Closed
Labels
bug Something isn't working
Milestone

Comments

@andrzej-stencel
Copy link
Contributor

Describe the bug

When upgrading from v1 to v2, if you have your Prometheus remoteWrite section overridden (that is entry prometheus-operator.prometheus.prometheusSpec.remoteWrite in values.yaml), the upgrade script does not add remoteTimeout parameter to the Fluentd remoteWrite entries. We consider this to be a bug, as the remoteTimeout parameter is crucial to ensure good performance when sending data from Prometheus to Fluentd.

To Reproduce

  1. Prepare a values.yaml file for v1 collection that has prometheus-operator.prometheus.prometheusSpec.remoteWrite entry customized.
  2. Run the upgrade script upgrade-2.0.0.sh
./upgrade-2.0.0.sh values.yaml
  1. Observe the prometheus-operator.prometheus.prometheusSpec.remoteWrite in the output file new_values.yaml.

Expected behavior

The prometheus-operator.prometheus.prometheusSpec.remoteWrite section in the output file should contain remoteTimeout parameter for the Fluentd remoteWrite entries.

Actual behaviour

The prometheus-operator.prometheus.prometheusSpec.remoteWrite section in the output file does not contain remoteTimeout parameter for the Fluentd remoteWrite entries.

@perk-sumo
Copy link
Contributor

Backport to v2.0: #1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants