Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid output of deprecations? #984

Open
s2b opened this issue Aug 21, 2024 · 3 comments
Open

Avoid output of deprecations? #984

s2b opened this issue Aug 21, 2024 · 3 comments

Comments

@s2b
Copy link
Contributor

s2b commented Aug 21, 2024

Other widespread PHP libraries seem to use the silencing operator @ when triggering exceptions. We should probably do the same in Fluid v4. We should check how this affects TYPO3's deprecation logs and test suite.

Related links:

@lolli42
Copy link
Member

lolli42 commented Aug 22, 2024

core does this: TYPO3/typo3@8140ec4
the code was moved around a bit over time, but it's still same strategy: log deprecations, even if it has the STFU operator.

@s2b
Copy link
Contributor Author

s2b commented Sep 2, 2024

I just tested this with phpunit's default error handler: The deprecation with STFU operator in fact is ignored by phpunit. TYPO3 on the other hand logs both kinds of deprecations.

So I would argue to only add the operator to deprecations that are added after a major release and to leave those for Fluid v4 without the operator.

What do you think?

@lolli42
Copy link
Member

lolli42 commented Sep 9, 2024

Sounds like a good trade-off. Let's see if we can manage to stick to this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants