Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player trails and MAX_PARTICLES #191

Open
Gelmo opened this issue Sep 15, 2023 · 0 comments
Open

Player trails and MAX_PARTICLES #191

Gelmo opened this issue Sep 15, 2023 · 0 comments

Comments

@Gelmo
Copy link
Member

Gelmo commented Sep 15, 2023

https://github.com/TeamForbiddenLLC/warfork-qfusion/blob/1bc009543f221d3fc4f790308bece33d1a6c2ebd/source/cgame/cg_effects.cpp#L560C10-L560C10

The current value of 2048 for MAX_PARTICLES is too low for player trails. Here's an example video:

https://streamable.com/byt303

You'll see that my trail starts mostly solid and with minimal sparks. However, once I add bots, my trail becomes more fragmented and more sparky as more players spawn in, start moving, and start generating particles of their own. I then remove the bots, and my trail returns to normal as players despawn.

Therefore, the more players that exist on the server, the worse player trails will look.

Additionally, since we're sharing MAX_PARTICLES with particles from other effects, player trails have an impact on existing particles (and the opposite).

I think trails should use a new variable, such as MAX_TRAILPARTICLES, and that should have a much higher limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants