Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Bug: Make app navigation responsive #24

Closed
3 of 4 tasks
KyleTryon opened this issue Sep 14, 2022 · 2 comments · Fixed by #34
Closed
3 of 4 tasks

Bug: Make app navigation responsive #24

KyleTryon opened this issue Sep 14, 2022 · 2 comments · Fixed by #34
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KyleTryon
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

image

image

image

Steps to reproduce

use chrome dev tools to show different devices and screen sizes.

Expected behavior

  1. Ensure the nav bar extends the full length of the page
  2. When small enough, the menu should no longer expand and should stay in the closed state. This functionality can easily be added now with the latest PR change: https://github.com/TechSquidTV/Shoutify/pull/23/files

Shoutify app version

No response

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

The nav component can be found here: https://github.com/TechSquidTV/Shoutify/blob/main/src/components/nav/AppNav.tsx
The nav is loaded as part of the page layout: https://github.com/TechSquidTV/Shoutify/blob/main/src/layouts/AppLayout.tsx

  • I suspect the layout isn't full-height.
@KyleTryon KyleTryon added bug Something isn't working good first issue Good for newcomers labels Sep 14, 2022
@takanome-dev
Copy link
Collaborator

@KyleTryon can you assign me this?

@KyleTryon
Copy link
Contributor Author

@KyleTryon can you assign me this?

Assigned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
2 participants