fix(ios): loss of touch end or cancel event in multi-finger scenarios #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a multi-finger scenario, the _touchBeganView local variable only records the last touch view since touch began is entered multiple times, causing the began and cancel/end events to be unmatched. To fix this, we use a simple approach - that record all touch began Views and send events to all recorded views at the end. Please note that we have not fully adapted the multi-fingered scenario.
github-actions
bot
added
renderer: native
size: s
|
Hi, @wwwcg. Thanks for your PR! 👏 🏷️ You can leave a comment in this PR with |
wwwcg
added a commit
to wwwcg/Hippy
that referenced
this pull request
Jun 11, 2024
…Tencent#3892) * fix(ios): loss of touch end or cancel event in multi-finger scenarios In a multi-finger scenario, the _touchBeganView local variable only records the last touch view since touch began is entered multiple times, causing the began and cancel/end events to be unmatched. To fix this, we use a simple approach - that record all touch began Views and send events to all recorded views at the end. Please note that we have not fully adapted the multi-fingered scenario. * fix(ios): resolve exception where touchView may be nil
wwwcg
added a commit
to wwwcg/Hippy
that referenced
this pull request
Jun 18, 2024
…Tencent#3892) * fix(ios): loss of touch end or cancel event in multi-finger scenarios In a multi-finger scenario, the _touchBeganView local variable only records the last touch view since touch began is entered multiple times, causing the began and cancel/end events to be unmatched. To fix this, we use a simple approach - that record all touch began Views and send events to all recorded views at the end. Please note that we have not fully adapted the multi-fingered scenario. * fix(ios): resolve exception where touchView may be nil
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a new pull request, please make sure: