From 1a56dc2c91d15e0a7d4f1cd160dbfd65ac9877ff Mon Sep 17 00:00:00 2001 From: southorange1228 <15280970040@163.com> Date: Thu, 28 Apr 2022 18:00:53 +0800 Subject: [PATCH 1/2] fix(slider): fix uncontrolled mode can't change value --- src/slider/Slider.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/slider/Slider.tsx b/src/slider/Slider.tsx index 3acc6f7d0..7433a832a 100644 --- a/src/slider/Slider.tsx +++ b/src/slider/Slider.tsx @@ -30,8 +30,8 @@ const Slider = forwardRef( range, step = 1, tooltipProps, - value: propsValue = min, - defaultValue, + value: propsValue, + defaultValue = min, onChange, className, style, @@ -121,7 +121,11 @@ const Slider = forwardRef( return ( handleInputChange(Number(value), nodeIndex)} + onChange={(value: number) => { + if (value) { + handleInputChange(Number(value), nodeIndex); + } + }} className={classNames(`${classPrefix}-slider-input`, { 'is-vertical': isVertical, })} From e6a11c1a08dc739667cf572808181c7669a45638 Mon Sep 17 00:00:00 2001 From: southorange1228 <15280970040@163.com> Date: Fri, 29 Apr 2022 12:20:36 +0800 Subject: [PATCH 2/2] fix(slider): fix inputNumber mode onChange event error --- src/slider/Slider.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/slider/Slider.tsx b/src/slider/Slider.tsx index 7433a832a..fa1a0bd81 100644 --- a/src/slider/Slider.tsx +++ b/src/slider/Slider.tsx @@ -121,9 +121,9 @@ const Slider = forwardRef( return ( { - if (value) { - handleInputChange(Number(value), nodeIndex); + onChange={(v: number) => { + if (typeof v !== 'undefined') { + handleInputChange(Number(v), nodeIndex); } }} className={classNames(`${classPrefix}-slider-input`, {