Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog 的 theme='danger' 无效 #2364

Closed
zww-v5 opened this issue Jul 12, 2023 · 3 comments
Closed

dialog 的 theme='danger' 无效 #2364

zww-v5 opened this issue Jul 12, 2023 · 3 comments
Labels
to be published fixed, not be published

Comments

@zww-v5
Copy link

zww-v5 commented Jul 12, 2023

tdesign-react 版本

tdesign-react@1.1.8

重现链接

No response

重现步骤

在 Dialog 组件中配置 theme='danger' 时，最终弹出的窗口没有出错的图标。
image
image

查看了下源码，写的是 error，而非 danger，但 ts 定义则是 danger，虽然用 theme='error' 可以显示错误类型的弹窗，但会报 ts 错误。
image
image

期望结果

希望支持 theme='danger' 的配置

实际结果

No response

框架版本

No response

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions
Copy link
Contributor

👋 @zww-v5，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@chaishi
Copy link
Collaborator

chaishi commented Jul 12, 2023

Vue 是 danger
React 需要改下代码

@chaishi chaishi mentioned this issue Jul 12, 2023
Merged
16 tasks
@chaishi
Copy link
Collaborator

chaishi commented Jul 12, 2023

fixed in #2365

@chaishi chaishi added the to be published fixed, not be published label Jul 12, 2023
@github-actions github-actions bot mentioned this issue Jul 19, 2023
Merged
16 tasks
@uyarn uyarn closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zww-v5 @chaishi @uyarn