-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tests for GitHub Service (Jest) #76
Comments
@omjogani Should we break this in multiple tests per filter? |
Breaking testes into multiple files: Bad Idea while everything resides in Breaking functionality into multiple test (filter wise or what so ever): Yes we should do that |
@omjogani I think we should break it and then break the tests too, let me know your thoughts? |
Well, that's better, I will work on refactoring that by end of this week! |
@omjogani Sure, take your time |
Description
We have a
GitHub
service, responsible for fetching all good first issues from GitHub, We want to have clean test suits. The testing environment is already configured in the project along with the test file (/__test__/services/github.test.ts
).Usage
to run all the tests run the following command
npm run test
Acceptance Criteria
except
in single test, rather breakdown those into multiple testsEngineering Notes
We're using
jest
for testing andjest-mock-extended
for mocking and other pre-made functions.Feel free to pick this issue and comment down below in case of any questions/feedback!
The text was updated successfully, but these errors were encountered: