Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new PDN from OpenROAD. #1038

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Switch to the new PDN from OpenROAD. #1038

merged 1 commit into from
Apr 11, 2022

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Apr 9, 2022

This PR fixes issue #1037 related to openroad new PDN behaviour.

(1) By two decimal rounding it fixes the error:

[ERROR PDN-0175] Pitch 28.8270 is too small for, must be atleast 28.8300

(2) Final conversion to new PDN part fixes the error:

Consider using "convert_pdn_config /home/cbalint/{...}/pdn_cfg.tcl" to convert the legacy configuration.
[INFO PDN-9008] Design name is spm.
[INFO PDN-9009] Reading technology data.
[ERROR PDN-9017] No stdcell grid specification found - no rails can be inserted.

This now pass latest openlane builds & regression .
Q: do we need discriminate within pdn.tcl the old vs new PDN or just lets go with it forward (drop old) ?

Cc @arlpetergadfort , @maliberty

Thanks,
~cristian.

scripts/openroad/pdn.tcl Outdated Show resolved Hide resolved
scripts/openroad/pdn.tcl Outdated Show resolved Hide resolved
scripts/tcl_commands/floorplan.tcl Outdated Show resolved Hide resolved
@cbalint13 cbalint13 requested a review from gadfort April 9, 2022 15:35
Signed-off-by: Balint Cristian <cristian.balint@gmail.com>
@cbalint13
Copy link
Contributor Author

cbalint13 commented Apr 9, 2022

@maliberty , @arlpetergadfort

Let's leave out from here the very failure on SPM, will need a separate fix (another PR) for the grid / rounding issue.


Q: For my understanding (for future fix), for the case of spm design sample, having FP_PDN_AUTO_ADJUST :

The grid i.e. 0.005 must be perfect divisor of that Pitch width/height numbers ?

  • If so, actual div() by 3.0 (for spm sample) in floorplan.tcl leads to infinite decimal , inevitably will round somewhere.
  • The final roundings of the div() (e.g 28.826666...) will never divide/align a fixed grid of 0.00X decimal number.

(Will debate this part on separate PR).

Thanks,
~cristian.

@cbalint13 cbalint13 requested a review from maliberty April 9, 2022 22:39
@donn
Copy link
Collaborator

donn commented Apr 11, 2022

@maliberty I need your review on this.

@maliberty
Copy link
Member

@donn I do not recommend merging this. @arlpetergadfort is working on making off-grid into an error. I do not think pdn should snap the user input.

I don't know why you are dividing by 3 but you should snap the result to the grid.

@cbalint13
Copy link
Contributor Author

@donn I do not recommend merging this. @arlpetergadfort is working on making off-grid into an error. I do not think pdn should snap the user input.

I don't know why you are dividing by 3 but you should snap the result to the grid.

@donn

Wait, @maliberty:

  1. I dropped out from here the part with roundings (will see another PR for that) !
  2. Let'ts just merge remaining part "source $::env(PDN_CFG) + pdngen" as new behavior, proposed by @arlpetergadfort .

Please have another quick look on this PR final diff summary.

@maliberty maliberty merged commit 6e35319 into The-OpenROAD-Project:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants