Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coin Change Problem in Dynamic Programming Section #117

Open
Swastyy opened this issue Jul 21, 2021 · 11 comments
Open

Coin Change Problem in Dynamic Programming Section #117

Swastyy opened this issue Jul 21, 2021 · 11 comments
Assignees
Labels
dont-close This issue/pull request shouldn't be closed enhancement good first issue

Comments

@Swastyy
Copy link
Contributor

Swastyy commented Jul 21, 2021

What is there in Coin Change.md?
Only a variation of unbounded Knapsack

Issue:
There exists many more variations like having a fixed number of coins or say a problem where we want to find the number of ways (ordered) a sum of money can be formed

Suggested Solution:
We can add these two explanations separately in files.

@Panquesito7
Copy link
Member

Thank you for your interest in contributing. 👍
Before submitting a PR, please ensure the following:

  • The algorithm isn't a duplicate in this repository in that language.
  • Follow the steps mentioned at the README.md.
  • Ensure that you include YouTube, Wikipedia, or any other links for algorithm explanation.

I'll look forward to reviewing your PR as soon as I can. Thank you. 🙂

@parthsarthi313
Copy link

I would like to contribute my code. There are various versions as Swastyy mentioned. I would try and cover all of them with explanation.

@Panquesito7
Copy link
Member

I would like to contribute my code. There are various versions as Swastyy mentioned. I would try and cover all of them with an explanation.

Feel free to create a PR. 🙂

@stale
Copy link

stale bot commented Sep 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@Swastyy
Copy link
Contributor Author

Swastyy commented Sep 20, 2021

Don't close.

@stale stale bot removed the stale label Sep 20, 2021
@Panquesito7 Panquesito7 added the dont-close This issue/pull request shouldn't be closed label Sep 20, 2021
@abhisheksharma010
Copy link

Hello, I would like to work on this, can it be assigned to me and I solved all the variation of coin changes

@appgurueu
Copy link
Collaborator

Sure, go ahead.

@abhisheksharma010
Copy link

@appgurueu I need your help with a pressing issue. Despite using the Clang Format extension in VS Code to format my code accurately, all jobs are consistently failing with the Clang Format linter. I'm at a loss as to why this is happening. Can you please assist me in resolving this matter as soon as possible?

@appgurueu
Copy link
Collaborator

@appgurueu I need your help with a pressing issue. Despite using the Clang Format extension in VS Code to format my code accurately, all jobs are consistently failing with the Clang Format linter. I'm at a loss as to why this is happening. Can you please assist me in resolving this matter as soon as possible?

Why do you need C(++) code for explaining algorithms? Just use pseudocode or more approachable scripting languages. For me to be able to help you with this, I'd need a link to the failing jobs.

@abhisheksharma010
Copy link

@appgurueu
Copy link
Collaborator

You're confusing things here. This is the Algorithms-Explanation repo, not the Java repo. I'm not a maintainer on the Java repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close This issue/pull request shouldn't be closed enhancement good first issue
Projects
None yet
Development

No branches or pull requests

5 participants