Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - :Grid exercises Solution and README.md contradicts each other for 01-responsive-holy-grail #606

Closed
3 tasks done
devnchill opened this issue Oct 7, 2024 · 1 comment · Fixed by #609
Closed
3 tasks done
Assignees
Labels
Status: In Progress This issue/PR has ongoing work being done

Comments

@devnchill
Copy link
Contributor

devnchill commented Oct 7, 2024

Complete the following REQUIRED checkboxes:

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this issue follows the Bug - location of bug: brief description of bug format, e.g. Bug - Grid exercises: CSS not properly linked to HTML files

The following checkbox is OPTIONAL:

  • I would like to be assigned this issue to work on it

1. Description of the Bug:

  • Last two points of self checks tells height of header and footer should increase on minimizing the width of overall website.
  • Even the screenshots show that thickness increases on minimizing the site using devtools.
  • But if use the solution it opposes that behaviour.
  • Thickness is directly proportional to width of website.
  • https://discord.com/channels/505093832157691914/505093832157691916/1292840680875622513
  • this talks about it with screenshots and recordings.

2. How To Reproduce:

Just use the code of solution and preview it , it will be visible there.

3. Expected Behavior:

I expected the solution to behave like it's mentioned in README.md (thickness perhaps height of header and footer is inversely proportional to width of website)

4. Desktop/Device:

  • Device: HP notebook 15.6 inch
  • OS: Arch Linux
  • Browser: chrome,brave
  • Version:

5. Additional Information:

@devnchill devnchill added Status: Needs Review This issue/PR needs an initial or additional review Type: Bug Involves something that isn't working as intended labels Oct 7, 2024
@MaoShizhong
Copy link
Contributor

The wording of the checks can definitely be improved for clarity. The "stretch taller" bit is mainly referring to row 3 (the "article" container) due to its p contents. We can just have the checks say that the columns narrow and widen as the viewport changes size, and some rows get taller to accommodate for any text wrapping.

Assigning this to you to reword.

@MaoShizhong MaoShizhong added Status: In Progress This issue/PR has ongoing work being done and removed Type: Bug Involves something that isn't working as intended Status: Needs Review This issue/PR needs an initial or additional review labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress This issue/PR has ongoing work being done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants