Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring tabs in the mix #50

Closed
TimGeyssens opened this issue Oct 8, 2020 · 5 comments
Closed

Bring tabs in the mix #50

TimGeyssens opened this issue Oct 8, 2020 · 5 comments
Labels

Comments

@TimGeyssens
Copy link
Owner

Install Matryoshka https://our.umbraco.com/packages/backoffice-extensions/matryoshka-tabs-for-umbraco-8/ (with nuget)

@prgriffithsdev
Copy link
Contributor

prgriffithsdev commented Oct 9, 2020

Hey Tim, ill add this package (Our.Umbraco.Matryoshka -Version 0.5.0) so I can implement and get a feel for the process to check-in and create a PR. I have the repo forked, cloned, running locally, and imported in uSync. Let me know the instructions e.g. do I work on main or create a feature\bugfix branch, creating a PR, any conventions to the commit message, etc. and ill get this added to ensure I can complete the pipeline correctly - am I able to assign this task to myself to avoid crossover with other contributors?

@TimGeyssens
Copy link
Owner Author

hey @prgriffithsdev awesome! Just comming and push to the main branch of your fork... then you can create pr with the github ui.

I'll check if I can open up the assignees bit... for now maybe just leave a comment... that you are handling this 👍

@prgriffithsdev
Copy link
Contributor

Cool, that's the PR all done and hopefully, it's correct, I've not contributed before :)

@TimGeyssens
Copy link
Owner Author

It is perfect :) thanks! And I think you just earned the Umbraco swag :)

@prgriffithsdev
Copy link
Contributor

Thanks, Tim, ill look through the issue list and see what else I can do. #onaroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants