Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage with GridLayers #11

Closed
IvanSanchez opened this issue Feb 23, 2017 · 3 comments
Closed

Document usage with GridLayers #11

IvanSanchez opened this issue Feb 23, 2017 · 3 comments

Comments

@IvanSanchez
Copy link

The example mentions "tile layers", and users might assume that this plugin works only with L.TileLayers.

Given that the plugin monkey-patches L.GridLayer, and that things like L.GridLayer.GoogleMutant interact with this plugin, I suggest adding a note to the readme, like

This plugin adds a new option to all instances of L.GridLayer and L.TileLayer:
@TolonUK
Copy link
Owner

TolonUK commented Feb 23, 2017

Well spotted, thanks.

... monkey-patches ...

Ouch! I assume by that you disapprove of my patching technique? ;)

@IvanSanchez
Copy link
Author

No, it's just how "extending the functionality of an existing javascript class prototype by replacing the implementation of one of its methods" is called in layman's terms 😄

@TolonUK
Copy link
Owner

TolonUK commented Feb 23, 2017

>.< How embarrassing...I'd best do some homework... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IvanSanchez @TolonUK