Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow rebuild times for ts-loader@2.0.1 #499

Closed
pelotom opened this issue Mar 14, 2017 · 8 comments
Closed

Slow rebuild times for ts-loader@2.0.1 #499

pelotom opened this issue Mar 14, 2017 · 8 comments

Comments

@pelotom
Copy link

pelotom commented Mar 14, 2017

Something appears to have changed between version 2.0.0 and 2.0.1 such that my rebuild times in --watch mode have ballooned from ~2s to ~20s. Time for first build has remained the same.

@pelotom pelotom changed the title Slow build times for ts-loader@2.0.1 Slow rebuild times for ts-loader@2.0.1 Mar 14, 2017
@johnnyreilly
Copy link
Member

I'm not experiencing the same myself; I'm not sure why you would be.

For what it's worth there was a breaking change in webpack that we had to cater for; code-wise the changes were pretty marginal: https://github.com/TypeStrong/ts-loader/releases/tag/v2.0.1

(For more background on the breaking change read this)

BTW are you running webpack 2?

@pelotom
Copy link
Author

pelotom commented Mar 14, 2017

Yes, I am running webpack 2, but I've tried with both webpack 1 and 2 and the problem exists in either case.

@johnnyreilly
Copy link
Member

Do you want to share your setup?

@pelotom
Copy link
Author

pelotom commented Mar 14, 2017

Unfortunately this is a private company repo so I can't share it wholesale. I can see about trying to create a minimal example that reproduces it when I get some time.

@johnnyreilly
Copy link
Member

Actually, I'm starting to wonder if this is related to the mtimes to getTimes() switch. See discussion in #497

@mmorton
Copy link

mmorton commented Mar 16, 2017

I am seeing the same thing on a large project that I too unfortunately cannot share. Rebuild is ~30s with 2.0.1 and only ~6s with 2.0.0. I can switch back and forth between versions and consistently see those numbers.

@johnnyreilly
Copy link
Member

Thanks for reporting. We've got a PR that looks like it may resolve the issue: #500

However since i haven't experienced it myself i can't be sure. Would you be able to give this PR a test drive and confirm if it fixes things?

@johnnyreilly
Copy link
Member

johnnyreilly commented Mar 16, 2017

Hopefully #500 (due to ship with 2.0.2) will fix this - closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants