revert: "fix: remove USD value impact" #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d51888a.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
just-toby
changed the title
just-toby
force-pushed
the
revert-457-WEB-2867-Widget-fix-price-slippage-in-widget
branch
from
dfc9d19
to
c6a4075
Compare
just-toby
commented
Mar 2, 2023
src/hooks/usePriceImpact.ts
Outdated
| @@ -22,6 +25,21 @@ export function usePriceImpact(trade?: InterfaceTrade): PriceImpact | undefined | |||
| }, [trade]) | |||
| } | |||
|
|
|||
| export function useFiatPriceImpact(trade?: InterfaceTrade) { | |||
There was a problem hiding this comment.
this logic was removed in the previous PR, i'm adding it back here
tinaszheng
suggested changes
Mar 7, 2023
|
addressed comments |
tinaszheng
approved these changes
Mar 8, 2023
just-toby
deleted the
revert-457-WEB-2867-Widget-fix-price-slippage-in-widget
branch
|
🎉 This PR is included in version 2.47.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #457 and updates it - see comments for details.
the main goal here is to show the correct % value based on the context it's in - fiat value impact next to the $ amount, slippage next to the word "slippage", etc