Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bnb chain support #532

Merged
merged 8 commits into from
Mar 7, 2023
Merged

feat: bnb chain support #532

merged 8 commits into from
Mar 7, 2023

Conversation

just-toby
Copy link
Collaborator

@just-toby just-toby commented Mar 3, 2023

based on the corresponding update in the interface: Uniswap/interface#6036

enables BNB as a supported Chain. this should allow the integrator (i.e. Token Detail Page) to pass a BNB provider without error.

image

successful quote between stables on BNB chain:
image

other pools don't have liquidity...

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
widgets ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 11:12PM (UTC)

@vercel vercel bot temporarily deployed to Preview March 3, 2023 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview March 3, 2023 21:43 Inactive
@just-toby just-toby marked this pull request as ready for review March 7, 2023 01:40
Copy link
Contributor

@JFrankfurt JFrankfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should change "bsc" to "bnb" or "BNB Chain" where possible

@vercel vercel bot temporarily deployed to Preview March 7, 2023 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview March 7, 2023 23:12 Inactive
@just-toby just-toby merged commit 27c5e7a into main Mar 7, 2023
@just-toby just-toby deleted the feat/bnb-chain-changes branch March 7, 2023 23:14
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

🎉 This PR is included in version 2.47.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants