fix: stricter typing for router query #548
Conversation
zzmp
requested review from
tinaszheng,
a team and
cartcrom
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -111,13 +111,13 @@ async function getQuote( | |||
| const amount = CurrencyAmount.fromRawAmount(baseCurrency, JSBI.BigInt(amountRaw ?? '1')) // a null amountRaw should initialize the route | |||
| const route = await router.route(amount, quoteCurrency, tradeType, /*swapConfig=*/ undefined, routerConfig) | |||
|
|
|||
| if (!amountRaw) return INITIALIZED | |||
| if (!route) return NO_ROUTE | |||
| if (!amountRaw) return { state: QuoteState.INITIALIZED } | |||
There was a problem hiding this comment.
when does this case happen? shouldn't this be part of the skipToken case?
There was a problem hiding this comment.
the slow part of CSSOR is initialization - that first time a token pair is checked. but it's not even getting the quote, it's initializing the data to get the quote.
so as soon as we have a pair, we make a query with a null amount, signifying that it's just an initialization. the client-side code will replace null with 1 so that it fetches the necessary initializing data, and then return QuoteState.INITIALIZED.
then, when we make a real query, it's nearly instant!
|
🎉 This PR is included in version 2.47.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Narrows typings for router queries, which avoids having to coerce types in useRouterTrade.
This will enable cleaner code for a planned perf event hook (see #549).
Also uncovers and fixes a bug for swaps with no quote (
QuoteState.NOT_FOUND), which do not include ablockNumberbut should still be rendered.