test: add filter to event feed #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zzmp
requested review from
a team and
lynnshaoyu
and removed request for
a team
lynnshaoyu
reviewed
Mar 16, 2023
lynnshaoyu
reviewed
Mar 16, 2023
| > | ||
| <option>{SHOW_ALL_EVENTS}</option> | ||
| {HANDLERS.map((name) => ( | ||
| <option key={name}>{name}</option> |
There was a problem hiding this comment.
any chance the handlers have the same name? could also use i (index) as key value for consistency with what you do on line 91
There was a problem hiding this comment.
leaving this as a runtime check - left a comment stating as such
lynnshaoyu
reviewed
Mar 16, 2023
lynnshaoyu
reviewed
Mar 16, 2023
lynnshaoyu
approved these changes
Mar 16, 2023
|
🎉 This PR is included in version 2.48.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a filter to the cosmos event feed to aid debugging.