fix: width of price impact speedbump #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vm
reviewed
Mar 16, 2023
| @@ -287,23 +287,21 @@ export function SummaryDialog(props: SummaryDialogProps) { | |||
| }, [ackPriceImpact, props.impact, showSpeedbump]) | |||
|
|
|||
| return ( | |||
| <> | |||
| <Column style={{ minWidth: isPageCentered ? Math.min(400, width) : 'auto', height: '100%' }} ref={setBoundary}> | |||
There was a problem hiding this comment.
could something like this work?
{{ minWidth: isPageCentered ? 400 : 'auto', width: isPageCentered: '100%': undefined, height: '100%' }}There was a problem hiding this comment.
also, is the 400 here related to the 420 width on speedbump?
There was a problem hiding this comment.
nope - this is just the min width of a page centered dialog. i've updated to name this value so it's more understandable.
vm
reviewed
Mar 16, 2023
just-toby
force-pushed
the
fix/warning-modal-746
branch
from
84282cb
to
a5abb98
Compare
vm
approved these changes
Mar 16, 2023
|
🎉 This PR is included in version 2.48.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust the max-width of the price impact speed bump content
https://www.notion.so/uniswaplabs/Weird-UI-state-of-warning-modal-746px-52f715bda79c466d89e5b08d374f10b5?pvs=4
test plan