fix: narrow WidgetPromise typings #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zzmp
commented
Mar 16, 2023
src/hooks/swap/useWrapCallback.tsx
Outdated
| case TransactionType.UNWRAP: | ||
| return { | ||
| response: await wrappedNativeCurrencyContract.withdraw(`0x${parsedAmountIn.quotient.toString(16)}`), | ||
| type: TransactionType.WRAP, | ||
| type: TransactionType.UNWRAP, |
There was a problem hiding this comment.
This is a current bug caught by narrower typings.
|
Types look good, it's quite a complex typing though but seems like it is necessary to accomplish what you need. Approving with my review based on code check, but please consider that I don't regularly work with this repo. |
mikeki
approved these changes
Mar 17, 2023
just-toby
approved these changes
Mar 17, 2023
|
🎉 This PR is included in version 2.48.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrows
WidgetPromisetypings such that we can be certain we are only triggering the events with promises that will reject in aWidgetError.This is primarily a refactor, but it adds type safety to the internals of the
PerfEventHandlers.