Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong redirect link for Run in VMUI #132

Closed
ehuzii opened this issue Jan 12, 2024 · 3 comments · Fixed by #135
Closed

Wrong redirect link for Run in VMUI #132

ehuzii opened this issue Jan 12, 2024 · 3 comments · Fixed by #135
Assignees

Comments

@ehuzii
Copy link

ehuzii commented Jan 12, 2024

Hello. judging by previous issues, the link is duplicated from the data source. but I see that the link is still generated incorrectly and does not work.
for example, in my case vmui host: vm.infra.dev
and correct ulr, if i want see my request in vmui: vm.infra.dev/vmui/?g0.expr=request
but grafana generate: vm.infra.dev/graph?g0.expr=request

this would work with Prometheus, but with vmui there is not enough path: vmui and graph suffix needs to be removed.

@hagen1778
Copy link
Contributor

@Loori-R could you please take a look?

@Loori-R Loori-R self-assigned this Jan 22, 2024
Loori-R added a commit that referenced this issue Jan 22, 2024
hagen1778 pushed a commit that referenced this issue Jan 25, 2024
@hagen1778
Copy link
Contributor

Hi @ehuzii! The issue was addressed in #132 and will be available in the next release. I'll keep this issue open until new release is cut.

@hagen1778 hagen1778 reopened this Jan 25, 2024
@Loori-R
Copy link
Contributor

Loori-R commented Jan 31, 2024

This issue has been fixed in datasource starting from v0.6.0. Closing the issue as fixed.

@Loori-R Loori-R closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants