New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using NativeEventEmitter instead of DeviceEventEmitter #153

Open

cristianoccazinsp opened this issue Jul 13, 2019 · 1 comment

Labels

cristianoccazinsp commented Jul 13, 2019

Any reason DeviceEventEmitter is being used? I've been testing using the recommended NativeEventEmitter and it seems to work fine.
https://facebook.github.io/react-native/docs/native-modules-ios#sending-events-to-javascript

Might also want to consider the following optimization from the docs:
https://facebook.github.io/react-native/docs/native-modules-ios#optimizing-for-zero-listeners

TSMMark added the help wanted label

pribeh commented Dec 6, 2019

bump

rsk7 mentioned this issue

Remove iOS identity events pitch45/react-native-background-upload#1

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment