Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak: switch to short type names in op names #356

Closed
lukewagner opened this issue Sep 16, 2015 · 3 comments
Closed

Tweak: switch to short type names in op names #356

lukewagner opened this issue Sep 16, 2015 · 3 comments

Comments

@lukewagner
Copy link
Member

One significant remaining divergence between ml-proto and design is that ml-proto uses short type names (i32 instead of int32). We've agreed that we want opcode names to exactly match AstSemantics.md, so one side needs to change. I actually like the short names better (shorter and no added ambiguity), so rather than changing ml-proto to match, how about we change design to use the short type names?

@sunfishcode
Copy link
Member

sgtm

@jfbastien
Copy link
Member

Agreed.

@lukewagner
Copy link
Member Author

Making a new issue for this was probably overkill. I'll close this issue and we can discuss in #357.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants