Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken with libwpe 1.14.0 #85

Closed
aperezdc opened this issue Sep 24, 2022 · 1 comment · Fixed by #86
Closed

Build broken with libwpe 1.14.0 #85

aperezdc opened this issue Sep 24, 2022 · 1 comment · Fixed by #86
Assignees
Labels

Comments

@aperezdc
Copy link
Contributor

Excerpt from the build failure:

src/input/Libinput/LibinputServer.cpp: In member function ‘bool WPE::LibinputServer::handleKeyboardEvent(uint32_t, uint32_t, uint32_t)’:
src/input/Libinput/LibinputServer.cpp:86:17: error: ‘wpe_input_xkb_context_get_default’ was not declared in this scope
   86 |     auto* xkb = wpe_input_xkb_context_get_default();
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:119:18: error: ‘wpe_input_xkb_context_get_key_code’ was not declared in this scope
  119 |         keysym = wpe_input_xkb_context_get_key_code(xkb, code, !!state);
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:126:22: error: ‘wpe_input_xkb_context_get_state’ was not declared in this scope
  126 |     auto* xkbState = wpe_input_xkb_context_get_state(xkb);
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:127:52: error: ‘XKB_KEY_DOWN’ was not declared in this scope
  127 |     xkb_state_update_key(xkbState, code, !!state ? XKB_KEY_DOWN : XKB_KEY_UP);
      |                                                    ^~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:127:67: error: ‘XKB_KEY_UP’ was not declared in this scope
  127 |     xkb_state_update_key(xkbState, code, !!state ? XKB_KEY_DOWN : XKB_KEY_UP);
      |                                                                   ^~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:127:5: error: ‘xkb_state_update_key’ was not declared in this scope
  127 |     xkb_state_update_key(xkbState, code, !!state ? XKB_KEY_DOWN : XKB_KEY_UP);
      |     ^~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:129:44: error: ‘XKB_STATE_MODS_DEPRESSED’ was not declared in this scope
  129 |         xkb_state_serialize_mods(xkbState, XKB_STATE_MODS_DEPRESSED),
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:129:9: error: ‘xkb_state_serialize_mods’ was not declared in this scope
  129 |         xkb_state_serialize_mods(xkbState, XKB_STATE_MODS_DEPRESSED),
      |         ^~~~~~~~~~~~~~~~~~~~~~~~
src/input/Libinput/LibinputServer.cpp:130:44: error: ‘XKB_STATE_MODS_LATCHED’ was not declared in this scope
  130 |         xkb_state_serialize_mods(xkbState, XKB_STATE_MODS_LATCHED),
      |                                            ^~~~~~~~~~~~~~~~~~~~~~
@aperezdc aperezdc added the bug label Sep 24, 2022
@aperezdc aperezdc self-assigned this Sep 24, 2022
@aperezdc
Copy link
Contributor Author

This is because WebPlatformForEmbedded/libwpe#94 added a compilation flag to the wpe-1.0.pc file, which cmake/FindWPE.cmake is not picking because it should be using ${PC_WPE_CFLAGS_OTHER} (instead of ${PC_WPE_CFLAGS}, which may look fine but is actually wrong!); and also after WebPlatformForEmbedded/libwpe#108 users of libwpe ough including the xkbcommon headers themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

1 participant