Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API version to everything that gets installed #10

Closed
mcatanzaro opened this issue Apr 7, 2018 · 3 comments
Closed

Add API version to everything that gets installed #10

mcatanzaro opened this issue Apr 7, 2018 · 3 comments

Comments

@mcatanzaro
Copy link
Contributor

We should add the API version to:

  • include directory path
  • installed library
  • pkg-config files

etc.

@mcatanzaro
Copy link
Contributor Author

I noticed this problem looking at my installed headers. WPE WebKit installs into /usr/include/wpe-0.1. WPEBackend installs into /usr/include/wpe.

One solution would be to put them both in wpe-0.1 and expect the API versions to be synced. But this means it will be almost impossible to ever change the WPEBackend API. It would surely be better for WPEBackend to not share an API version with WPE WebKit. This means we should either:

  • Come up with a different API name for WPEBackend, e.g. "wpe-backend-0.1" instead of "wpe"; or
  • Install WPE WebKit's headers differently, e.g. under wpe-webkit-0.1 instead of wpe-0.1

The later solution seems nicer to me.

@mcatanzaro
Copy link
Contributor Author

Also, I notice this:

set_target_properties(WPEBackend PROPERTIES VERSION ${WPE_VERSION} SOVERSION ${WPE_VERSION_MAJOR})

which is maybe OK, but means you can't make any ABI changes without bumping the major version. If that's intended, then OK.

@mcatanzaro
Copy link
Contributor Author

WPE WebKit installs into /usr/include/wpe-0.1. WPEBackend installs into /usr/include/wpe.

Well, currently WPE WebKit uses /usr/include/wpe-0.1/WPE, but I remove the last WPE part in this bug and then we wind up with this conflict. My suggestion would be to use /usr/include/wpe-webkit-0.1/ instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant