Fix build failure due to libc++ using libc functions #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
added
bug
merge:libwpe-1.12
aperezdc
requested review from
alexgcastro,
carlosgcampos,
clopez,
philn and
zdobersek
Include the "alloc-private.h" header after the C++ standard library headers. This sidesteps build failures caused by implementations of std::map and std::string which use libc memory allocation functions in expanded templates after they have been marked with the "poison" pragma. Fixes #115
aperezdc
force-pushed
the
aperezdc/fix-libcxx-build
branch
from
56ae5da
to
3298cd1
Compare
philn
approved these changes
Aug 4, 2022
|
Cherry-picked into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the
alloc-private.hheader after the C++ standard library headers. This sidesteps build failures caused by implementations ofstd::mapandstd::stringwhich use libc memory allocation functions in expanded templates after they have been marked with thepoisonpragma.Fixes #115