cmake: Pass -Wall and check that compiler flags are supported #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds checks to ensure that command line flags passed to the C/C++ copmilers are supported before adding them to the list of flags. This also leaves to CMake the responsibility of determining which compiler flags are needed to choose C++11/C99, instead of passing -std=xyz, because different compilers might use other options for this.
|
Ping reviewers. |
zdobersek
approved these changes
Aug 12, 2019
|
Thanks @zdobersek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks to ensure that command line flags passed to the C/C++ copmilers are supported before adding them to the list of flags. This also leaves to CMake the responsibility of determining which compiler flags are needed to choose C++11/C99, instead of passing
-std=xyz, because different compilers might use other options for this.Closes #49