Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4.0 tarball/build generates version.h for 1.3.91 #60

Closed
philn opened this issue Sep 30, 2019 · 4 comments
Closed

1.4.0 tarball/build generates version.h for 1.3.91 #60

philn opened this issue Sep 30, 2019 · 4 comments
Assignees
@aperezdc
Labels
bug

Comments

@philn
Copy link
Collaborator

philn commented Sep 30, 2019 

cat ../libwpe-1.4.0/DerivedSources/wpe/version.h
...
#define WPE_MAJOR_VERSION (1)
#define WPE_MINOR_VERSION (3)
#define WPE_MICRO_VERSION (91)
...
@philn
Copy link
Collaborator Author

philn commented Sep 30, 2019

CMakeLists.txt of the 1.4.0 tarball has SET_PROJECT_VERSION(1 3 91)

@philn
Copy link
Collaborator Author

philn commented Sep 30, 2019 •
edited
Loading

Perhaps a brown-paper-bag 1.4.0.1 release would be good to have @aperezdc ?

@aperezdc
Copy link
Contributor

aperezdc commented Sep 30, 2019 •
edited
Loading

My bad, I did update the version numbers in commit 8789322 but I must have uploaded the tarball resulting from make distcheck before doing the commit with the version update (which is the only one missing in the tarball).

I'll make a 1.4.0.1 release, thanks for the heads up!

@aperezdc aperezdc added the bug label Sep 30, 2019
@aperezdc aperezdc self-assigned this Sep 30, 2019
@aperezdc
Copy link
Contributor

aperezdc commented Oct 1, 2019

Done, release 1.4.0.1 is now available.

@aperezdc aperezdc closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezdc aperezdc

Labels
bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philn @aperezdc