Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the .nvmrc node version to the changes made in commit ec2605b #972

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

rowasc
Copy link
Contributor

@rowasc rowasc commented Jan 24, 2024

What is this PR doing?

It changes the minimum version of node in .nvmrc to the same version stated as a minimum here

What problem is it solving?

I was updating trunk, and ran nvm use and npm install. When running npm install, I got an error:

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @php-wasm/compile@0.1.5
npm ERR! notsup Not compatible with your version of node/npm: @php-wasm/compile@0.1.5

How is the problem addressed?

I changed the minimum version in the .nvmrc so that it matches the value stated here

Testing Instructions

Run:

  • nvm use
  • nvm install
  • npm run dev

You should be able to run WP Playground and not get stuck on the npm install step with an error.

I was getting a mismatched version error after running `nvm use` and `npm install` on the latest version of `trunk`. I checked and saw that the minimal version changed [here](WordPress@ec2605b#diff-7b99c1171afa5312d8c4adb6d14112de87c1776eaa38d93e32082d37fe27c42fR41) and I changed it locally to match. Now `nvm use` and `npm install` both work as expected.
@rowasc rowasc requested a review from a team as a code owner January 24, 2024 15:56
@adamziel adamziel merged commit 974e0d3 into WordPress:trunk Jan 25, 2024
5 checks passed
@adamziel
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants