Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite color utility to use ChromaJS #229

Closed
lychyi opened this issue Sep 30, 2019 · 2 comments
Closed

Rewrite color utility to use ChromaJS #229

lychyi opened this issue Sep 30, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@lychyi
Copy link
Contributor

lychyi commented Sep 30, 2019

🚀 Feature Proposal

Upgrade Chroma JS to version 2.x (2.0.6 as of writing)

Motivation

We use Chroma for some color manipulations and we also export a function that calculates color usage based on accessibility which Chroma already does.

Outline

  • Update chroma-js to 2.x
  • Update @types/chroma-js to latest
  • Rewrite the color utility that picks foreground color to only use Chroma instead of calculating relative lum (no need to re-invent the wheel)
@lychyi lychyi added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file and removed dependencies Pull requests that update a dependency file labels Sep 30, 2019
@lychyi lychyi mentioned this issue Dec 4, 2019
Merged
9 tasks
@anicholls
Copy link
Contributor

Updated chroma-js version to 2.1.0 as part of #272. Still need to rewrite the color utility though.

@anicholls anicholls changed the title Update to Chroma JS 2.x Rewrite color utility to use ChromaJS Dec 5, 2019
@jpante jpante added the p:3 label Apr 13, 2020
@jpante jpante added p:2 and removed p:3 labels Apr 13, 2020
@NicholasBoll
Copy link
Member

Fixed by #700

@jaclynjessup jaclynjessup removed p:2 enhancement New feature or request labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@NicholasBoll @anicholls @jpante @lychyi @jaclynjessup