From 3a359a2f910ee7d3357dc3a0b22ed2b4575461c5 Mon Sep 17 00:00:00 2001
From: Antoine Martin <totaam@xpra.org>
Date: Fri, 3 Aug 2018 17:03:48 +0000
Subject: [PATCH] #1646: simulate remote command probing via 'type' on win32,
 and fixup error handling: use generic send method with timeout (just in case)

git-svn-id: https://xpra.org/svn/Xpra/trunk@20015 3bb7dfac-3a0b-4e04-842a-767bc560f471
---
 src/xpra/server/ssh.py | 44 ++++++++++++++++++++++++++++--------------
 1 file changed, 30 insertions(+), 14 deletions(-)

diff --git a/src/xpra/server/ssh.py b/src/xpra/server/ssh.py
index aad9abb306..5e49e3cf80 100644
--- a/src/xpra/server/ssh.py
+++ b/src/xpra/server/ssh.py
@@ -16,7 +16,8 @@
 
 from xpra.net.ssh import SSHSocketConnection
 from xpra.util import csv, envint
-from xpra.os_util import osexpand, getuid, WIN32, POSIX
+from xpra.os_util import osexpand, getuid, bytestostr, WIN32, POSIX,\
+    monotonic_time
 from xpra.platform.paths import get_ssh_conf_dirs
 
 
@@ -115,31 +116,46 @@ def check_channel_shell_request(self, channel):
         return False
 
     def check_channel_exec_request(self, channel, command):
+        def chan_send(send_fn, data, timeout=5):
+            start = monotonic_time()
+            while data and monotonic_time()-start<timeout:
+                sent = send_fn(data)
+                if not sent:
+                    break
+                data = data[sent:]
         #TODO: close channel after use? when?
         log("check_channel_exec_request(%s, %s)", channel, command)
-        cmd = shlex.split(command)
+        try:
+            cmd = shlex.split(command.decode("utf8"))
+        except UnicodeDecodeError:
+            cmd = shlex.split(bytestostr(command))            
         if cmd[0]=="type" and len(cmd)==2:
+            xpra_cmd = cmd[1]   #ie: $XDG_RUNTIME_DIR/xpra/run-xpra or "xpra"
+            if not POSIX:
+                assert WIN32
+                #we can't execute "type" on win32,
+                #so we just answer as best we can
+                #and only accept "xpra" as argument:
+                if xpra_cmd.strip("\"")=="xpra":
+                    chan_send(channel.send, "xpra is xpra")
+                    channel.send_exit_status(0)
+                else:
+                    chan_send(channel.send_stderr, "type: %s: not found" % xpra_cmd)
+                    channel.send_exit_status(1)
+                return
             #we don't want to use a shell,
             #but we need to expand the file argument:
-            cmd[1] = osexpand(cmd[1])
+            cmd[1] = osexpand(xpra_cmd)
             try:
                 proc = Popen(cmd, stdin=None, stdout=PIPE, stderr=PIPE, close_fds=not WIN32, shell=False)
                 out, err = proc.communicate()
             except Exception as e:
                 log("check_channel_exec_request(%s, %s)", channel, command, exc_info=True)
-                channel.send_stderr("failed to execute command: %s", e)
+                chan_send(channel.send_stderr, "failed to execute command: %s" % e)
                 channel.send_exit_status(1)
             else:
-                while out:
-                    sent = channel.send(out)
-                    if not sent:
-                        break
-                    out = out[sent:]
-                while err:
-                    sent = channel.send_stderr(err)
-                    if not sent:
-                        break
-                    err = err[sent:]
+                chan_send(channel.send, out)
+                chan_send(channel.send_stderr, err)
                 channel.send_exit_status(proc.returncode)
         elif cmd[0].endswith("xpra") and len(cmd)>=2:
             subcommand = cmd[1].strip("\"'")