From 59631535f885c27fceade26f9875405452ed82e6 Mon Sep 17 00:00:00 2001
From: Antoine Martin <antoine@xpra.org>
Date: Fri, 5 Jul 2024 14:09:14 +0700
Subject: [PATCH] don't use d3d11 capture with VirtualBox

---
 xpra/platform/win32/shadow_server.py | 40 +++++++++++++++++++++++-----
 xpra/util/system.py                  | 31 +++++++++++++++++++++
 2 files changed, 64 insertions(+), 7 deletions(-)

diff --git a/xpra/platform/win32/shadow_server.py b/xpra/platform/win32/shadow_server.py
index 9aafe4a441..40af6dbe80 100644
--- a/xpra/platform/win32/shadow_server.py
+++ b/xpra/platform/win32/shadow_server.py
@@ -14,6 +14,7 @@
 from xpra.util.screen import prettify_plug_name
 from xpra.util.str_fn import csv
 from xpra.util.env import envbool
+from xpra.util.system import is_VirtualBox
 from xpra.common import XPRA_APP_ID, NotificationID
 from xpra.scripts.config import InitException
 from xpra.server.gtk_server import GTKServerBase
@@ -53,7 +54,37 @@
 GDI = envbool("XPRA_SHADOW_GDI", True)
 GSTREAMER = envbool("XPRA_SHADOW_GSTREAMER", True)
 
-GSTREAMER_CAPTURE_ELEMENTS: Sequence[str] = ("d3d11screencapturesrc", "dx9screencapsrc", "gdiscreencapsrc")
+
+def check_gstreamer_d3d11() -> bool:
+    return not is_VirtualBox()
+
+
+def check_gstreamer_dx9() -> bool:
+    return True
+
+
+def check_gstreamer_gdi() -> bool:
+    # we don't want to be using GStreamer for GDI capture
+    return False
+
+
+def get_gstreamer_capture_elements() -> Sequence[str]:
+    if "XPRA_GSTREAMER_CAPTURE_ELEMENTS" in os.environ:
+        elements = os.environ.get("XPRA_GSTREAMER_CAPTURE_ELEMENTS", "").split(",")
+    else:
+        elements = []
+        for element, check in {
+            "d3d11screencapturesrc" : check_gstreamer_d3d11,
+            "dx9screencapsrc": check_gstreamer_dx9,
+            "gdiscreencapsrc": check_gstreamer_gdi,
+        }.items():
+            if envbool("XPRA_GSTREAMER_CAPTURE_"+element.upper(), False) or check():
+                elements.append(element)
+    log(f"get_gstreamer_capture_elements()={elements}")
+    return elements
+
+
+GSTREAMER_CAPTURE_ELEMENTS: Sequence[str] = get_gstreamer_capture_elements()
 
 
 def check_gstreamer() -> bool:
@@ -159,12 +190,7 @@ def init_capture(w: int, h: int, pixel_depth=32):
         except ImportError:
             log("no GStreamer capture", exc_info=True)
         else:
-            capture_elements = [
-                "d3d11screencapturesrc",
-                "dx9screencapsrc",
-                # "gdiscreencapsrc",
-            ]
-            for el in capture_elements:
+            for el in GSTREAMER_CAPTURE_ELEMENTS:
                 log(f"testing gstreamer capture using {el}")
                 try:
                     capture = Capture(el, pixel_format="BGRX", width=w, height=h)
diff --git a/xpra/util/system.py b/xpra/util/system.py
index f7837953d2..f8a0df50de 100644
--- a/xpra/util/system.py
+++ b/xpra/util/system.py
@@ -60,6 +60,37 @@ def sigusr2(*_args):
     signal.signal(signal.SIGUSR2, sigusr2)
 
 
+def is_VirtualBox() -> bool:
+    if os.name != "nt":
+        # detection not supported yet
+        return False
+    # try to detect VirtualBox:
+    # based on the code found here:
+    # http://spth.virii.lu/eof2/articles/WarGame/vboxdetect.html
+    try:
+        from ctypes import cdll
+        if cdll.LoadLibrary("VBoxHook.dll"):
+            # "VirtualBox is present (VBoxHook.dll)
+            return True
+    except (ImportError, OSError):
+        pass
+    try:
+        try:
+            f = None
+            f = open("\\\\.\\VBoxMiniRdrDN", "r")
+            # "VirtualBox is present (VBoxMiniRdrDN)"
+            return True
+        finally:
+            if f:
+                f.close()
+    except Exception as e:
+        import errno
+        if e.args[0]==errno.EACCES:
+            # "VirtualBox is present (VBoxMiniRdrDN)"
+            return True
+    return False
+
+
 def is_Wayland() -> bool:
     return _is_Wayland(_saved_env)