Starting a session over SSH causes duplicate start children

[totaam]

Issue migrated from trac ticket # 1940

component: core | priority: minor | resolution: fixed

2018-08-24 23:25:39: maxmylyn created the issue

---

I found this one while following up on #1920 and #1646:

Starting a session via SSH by running xpra start ssh:user@host --start-new-commands=yes --start=xterm causes two Xterms to appear. Starting a session with xpra start ssh:vorfuehreffekt --start-new-commands=no --start=xterm does not cause the duplication - only one Xterm window appears for the session.

The issue seems to be limited to --start-new-commands=yes, and it's a minor issue at that.

I'm not sure what logs to get - I have -d all piped into a .log file but I'm not sure how much use that will be. Reproducing is very easy, simply start with:

xpra start ssh:user@host --start-new-commands=yes --start=xterm and you'll see two Xterms pop up.

[totaam]

2018-08-26 17:50:06: antoine changed status from new to assigned

[totaam]

2018-08-26 17:50:06: antoine commented

---

Odd, the server command line actually used looks fine:

$ xpra info | grep server.argv
server.argv=('/usr/bin/xpra', 'start', '--start=xterm', '--start-new-commands=yes', \
    '--env=XPRA_PROXY_START_UUID=41a73c090ea64db6b540d0ad89f105cc', \
    '--daemon=yes', '--systemd-run=no', '--displayfd=5', \
    '--start-via-proxy=no')

(with system proxy turned off)

[totaam]

2018-08-26 21:18:31: antoine changed status from assigned to closed

[totaam]

2018-08-26 21:18:31: antoine set resolution to fixed

[totaam]

2018-08-26 21:18:31: antoine commented

---

Doh, this is caused by r20046 for #1931.
Fixed in r20211.