Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal is not correct showing on api level 17 #2

Closed
liufuxin opened this issue Mar 31, 2015 · 5 comments · Fixed by #3
Closed

Reveal is not correct showing on api level 17 #2

liufuxin opened this issue Mar 31, 2015 · 5 comments · Fixed by #3

Comments

@liufuxin
Copy link

On emulator nexus s the Reveal animation is not correct,show a RectReveal not a CircularReveal ,But when run the Slide-Menu depends on Ozodrukh's animation util for CircularReveal animation is correct on the same level emulator.

Is that a Os problem?

@liufuxin liufuxin changed the title Reveal not correct on api level 17 Reveal is not correct showing on api level 17 Mar 31, 2015
@shliama
Copy link
Contributor

shliama commented Apr 1, 2015

@liufuxin Thanks for report. I'm going to take a look at this bug this week. Not sure when, but till the end of the week I'll post an update here.

@shliama
Copy link
Contributor

shliama commented Apr 4, 2015

@liufuxin ok, so I've checked this on genymotion emulator Nexus 4 with API 17 and successfully reproduced this bug. Also I've reproduced the same bug in Slide-Menu app :) Not sure yet, is it genymotion issue or bug of android 4.2 or both...
I'm going to try to reproduce the bug on real device with android 4.2 on Monday, and post update here.

@liufuxin
Copy link
Author

liufuxin commented Apr 8, 2015

@shliama I've checked this on real device with android 4.2.1,the animation shows the correct in Slide-Menu app,but not in Euclid.

@shliama
Copy link
Contributor

shliama commented Apr 8, 2015

@liufuxin indeed. I've double-checked this on real device too and reproduced bug with this library and this one [https://github.com/Yalantis/Side-Menu.Android].
They both depends on this library [https://github.com/ozodrukh/CircularReveal] to make circle reveal animation. Also I've found this issue [https://github.com/ozodrukh/CircularReveal/issues/11] in which said that this bug is due to hardware acceleration. As you can see, it's not seems to be fixed yet.

It's kind of bad practice to disable HV for the whole app or activity, but I'm going to try to disable it for a single reveal view. Will post updates here.

@shliama
Copy link
Contributor

shliama commented Apr 8, 2015

@liufuxin I've found a problem in CircularReveal library, it was enabling hardware acceleration for API 17, when clipPath() works with hardware acceleration only from API 18 [http://developer.android.com/guide/topics/graphics/hardware-accel.html#unsupported]

I've included that lib as local module and made all needed fixes. For now, I've pushed these changes in the separate branch named <hardware_acceleration_fix>. So you can pull/include/use it for now.
By the way, it work not that smooth with HA disabled :(

I'm going to create pull-request to that library, and when/if it accepted, I'll update master branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants