-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reveal is not correct showing on api level 17 #2
Comments
@liufuxin Thanks for report. I'm going to take a look at this bug this week. Not sure when, but till the end of the week I'll post an update here. |
@liufuxin ok, so I've checked this on genymotion emulator Nexus 4 with API 17 and successfully reproduced this bug. Also I've reproduced the same bug in Slide-Menu app :) Not sure yet, is it genymotion issue or bug of android 4.2 or both... |
@shliama I've checked this on real device with android 4.2.1,the animation shows the correct in Slide-Menu app,but not in Euclid. |
@liufuxin indeed. I've double-checked this on real device too and reproduced bug with this library and this one [https://github.com/Yalantis/Side-Menu.Android]. It's kind of bad practice to disable HV for the whole app or activity, but I'm going to try to disable it for a single reveal view. Will post updates here. |
@liufuxin I've found a problem in CircularReveal library, it was enabling hardware acceleration for API 17, when clipPath() works with hardware acceleration only from API 18 [http://developer.android.com/guide/topics/graphics/hardware-accel.html#unsupported] I've included that lib as local module and made all needed fixes. For now, I've pushed these changes in the separate branch named <hardware_acceleration_fix>. So you can pull/include/use it for now. I'm going to create pull-request to that library, and when/if it accepted, I'll update master branch too. |
On emulator nexus s the Reveal animation is not correct,show a RectReveal not a CircularReveal ,But when run the Slide-Menu depends on Ozodrukh's animation util for CircularReveal animation is correct on the same level emulator.
Is that a Os problem?
The text was updated successfully, but these errors were encountered: