Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: cannot import name SensitivityValues #4

Closed
dcepler opened this issue Aug 24, 2018 · 2 comments
Closed

ImportError: cannot import name SensitivityValues #4

dcepler opened this issue Aug 24, 2018 · 2 comments

Comments

@dcepler
Copy link

dcepler commented Aug 24, 2018

When installing latest version of detect-secrets-server using:

git clone https://github.com/Yelp/detect-secrets-server.git /usr/share/detect-secrets-server
pip install /usr/share/detect-secrets-server

I have the following error when trying to execute detect-secrets-server:

Traceback (most recent call last):
  File "/usr/local/bin/detect-secrets-server", line 7, in <module>
    from detect_secrets_server.__main__ import main
  File "/usr/local/lib/python2.7/dist-packages/detect_secrets_server/__main__.py", line 9, in <module>
    from detect_secrets.plugins import SensitivityValues
ImportError: cannot import name SensitivityValues

The class SensitivityValues has been deleted from detect-secrets as noted in this PR Yelp/detect-secrets#44. It references that detect-secrets-server should be pinned to specific version but the README.md does not say which version.

I was able to install using pip with the following pinned version

pip install detect-secrets==0.8.8
pip install detect-secrets-server

Either README.md needs to be updated or the detect-secrets-server code needs to be updated accordingly.

@KevinHock
Copy link
Collaborator

Sorry about that. Thank you more making this @dcepler 👍

I have added at the top of the README.md that
"It currently is only compatible with version 0.8.8 of detect-secrets." It is on our backlog to make the open-source version of the server compatible with the latest detect-secrets but hopefully this will due in the meantime.

@domanchi
Copy link
Contributor

Closing this issue, as this issue no longer exists with the new version of detect-secrets-server (0.2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants