This repository has been archived by the owner on Oct 5, 2019. It is now read-only.
More tests for VirusTotal LookupHashesFilter and LookupDomainsFilter #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't follow the pattern of testing used for other filters. What they do is:
The benefit of this is that a test like this exercises more of the API code and would be consistent with the existing codebase. |
|
I have added the cache for test data and removed the mocks for VirusTotalApi. |
| @@ -74,6 +74,12 @@ def assert_key_added_to_blob(self, added_key, expected_values, input_blobs, outp | |||
| del output_blob[added_key] | |||
| assert_equal_sorted(input_blob, output_blob) | |||
|
|
|||
| def load_reports(self, filename): | |||
ivanlei
pushed a commit
that referenced
this pull request
Feb 17, 2015
More tests for VirusTotal LookupHashesFilter and LookupDomainsFilter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51 and #52.