Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'static to Ciphersuite trait #693

Open
conradoplg opened this issue Jun 21, 2024 · 0 comments · May be fixed by #701
Open

Add 'static to Ciphersuite trait #693

conradoplg opened this issue Jun 21, 2024 · 0 comments · May be fixed by #701
Assignees

Comments

@conradoplg
Copy link
Contributor

It's a common pattern to use Box<dyn std::error::Error> to represent any type of error. However, if you try to convert a frost_core::Error<C> into it, the compiler requires adding a 'static bound to the function (e.g. <C: Ciphersuite + 'static>. The reason is explained here.

We can simply add the 'static bound to Ciphersuite ourselves, which would then not require doing it in every function that uses that pattern. (This came up while converting the demo code to use generics).

This is a breaking change (and a simple one) so I think we can add it to the 2.0.0 release.

@mpguerra mpguerra changed the title Add 'static to Ciphersuite trait Add 'static to Ciphersuite trait Jun 25, 2024
@mpguerra mpguerra added this to the FROST v2.0.0 Release milestone Jun 25, 2024
@conradoplg conradoplg linked a pull request Jul 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging a pull request may close this issue.

2 participants