New User Permission "Groups" #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only issue I see is the use of short php tags in console.php |
|
Fixed. Good catch. I had copied/pasted that line from an old version of console.php. |
connortechnology
added a commit
that referenced
this pull request
Aug 16, 2015
New User Permission "Groups"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541
This PR adds a new permission called Groups, which gives the sys admin the ability to manage monitor group view/edit permissions without also giving the user permission to the rest of the System.
This turned out to be more involved than I had initially anticipated.
@barjac owes me big.
Please test this and be on the look out for anything unexpected in the logs.