Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative URL's instead of absolute #1121

Merged
merged 1 commit into from
Nov 3, 2015

Conversation

knight-of-ni
Copy link
Member

I do not know of any negative side effects with using relative url's instead of absolute.
Let's get this into master and test.

@SteveGilvarry
Copy link
Member

No issues with my testing of this either, happy to merge? If so I will do it.
Only question I had is with only 3 places that use ZM_BASE_URL is this part one to ensure it has not effect before removing it altogether?

@knight-of-ni
Copy link
Member Author

Yeah, pretty much. I'm extremely hesitant to change things that have been working a particular way since the beginning of zoneminder. This is one of those cases. We have a really good reason to change it, but from past experience there have been those who use zoneminder in ways we don't anticipate whom we have affected. I can't think of what that would be in this case, but I still chose to play it safe.

If for some reason this merge causes an unforeseen problem, I made it real obvious for anyone to see how to change it back. We can remove the comments in a future revision.

Thank you for merging.

SteveGilvarry added a commit that referenced this pull request Nov 3, 2015
Use relative URL's instead of absolute
@SteveGilvarry SteveGilvarry merged commit 5a931db into ZoneMinder:master Nov 3, 2015
@knight-of-ni knight-of-ni deleted the revproxy branch November 24, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants