Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTSP Improvements #612

Closed
knight-of-ni opened this issue Dec 1, 2014 · 1 comment
Closed

RTSP Improvements #612

knight-of-ni opened this issue Dec 1, 2014 · 1 comment

Comments

@knight-of-ni
Copy link
Member

This is primarily for myself so I don't forget to work on these. Generally, I know how to fix them, but I need time to stumble through my lack of c++ knowledge.

  • RTP-Info field should be made non-fatal. Not all cameras send this information, and it can work without it.
  • Zoneminder checks for the RTSP timeout after the SETUP command is sent, which it should. However, some devices don't send the timeout value until after the PLAY command is sent. Add a second check for the timeout and update the value if it = 0.
  • Add SDP MediaType of "application". This media type is an extra metadata stream the camera can send. ZoneMinder does not need to read this stream, but it does need to know a little about the stream so it does not abort. Grandstream firmware supports this mediatype.
  • Fix the following bug in the RTSP logic.
    The current RTSP logic does not support RTP-Info that contains more than one stream. According to RFC2326, multiple streams can be sent like so:
RTP-Info: url=rtsp://foo.com/bar.avi/streamid=0;seq=45102;rtptime=972948234,
url=rtsp://foo.com/bar.avi/streamid=1;seq=30211;rtptime=972948234

Zoneminder currently (always) uses the sequence and rtptime from the second stream, which naturally is not correct if the first stream is the one that is being viewed.

@knight-of-ni knight-of-ni mentioned this issue Dec 1, 2014
@knight-of-ni
Copy link
Member Author

This issue has been resolved. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant