Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo tomllib no-infer-dep #1

Closed
jsirois opened this issue Jan 22, 2023 · 2 comments
Closed

Undo tomllib no-infer-dep #1

jsirois opened this issue Jan 22, 2023 · 2 comments

Comments

@jsirois
Copy link
Contributor

jsirois commented Jan 22, 2023

Right here:

# This `no-infer-dep` will not be needed once we upgrade ti a version of Pants that fixes:
# https://github.com/pantsbuild/pants/issues/18055
import tomllib # pants: no-infer-dep

The switch from tomli to the stdlib occurred in 24f3995. That also upgraded to Pants 2.15.0rc2. When we can upgrade to a version of Pants that fixes this lack of knowledge of the tomllib stdlib, we can undo the no-infer-dep.

@jsirois
Copy link
Contributor Author

jsirois commented Jan 22, 2023

The Pants issue tracking this is here: pantsbuild/pants#18055

@jsirois
Copy link
Contributor Author

jsirois commented Apr 23, 2023

Killed this comment in 0489944 since it's no longer required with the switch from Pants to Nox.

@jsirois jsirois closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant