Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support page layout #45

Closed
ulivz opened this issue Jan 25, 2022 · 0 comments · Fixed by #46
Closed

[feature request] support page layout #45

ulivz opened this issue Jan 25, 2022 · 0 comments · Fixed by #46

Comments

@ulivz
Copy link
Owner

ulivz commented Jan 25, 2022

Motivation

Currently if we want to custom the page's layout (e.g. hidden sidebar, toc and pageEdit), we need hidden it via frontmatter one by one:

---
toc: false
pageEdit: false
sidebar: false
---

And after #42 is merged, the page' container style is not aligned and is hard to control, it's not friendly for users who only wants to use a fully different page layout and only remain Header.

API Design

Introduce a new frontmatter option BlogPage:

---
pageLayout: BlogPage
---

The the page will be rendered with the component, and we don't need to hack any internal styles.

@ulivz ulivz closed this as completed in #46 Jan 25, 2022
ulivz added a commit that referenced this issue Jan 25, 2022
* feat(theme): support page layout (close: #45)

* chore: address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant