Mods do not get removed from game config when GAME_MODS_IDS_LIST is empty

[hafometh88]

Describe the bug
I am not sure if it this a bug or a feature request, but mod IDs do not get removed from the server config when I leave GAME_MODS_IDS_LIST empty

To Reproduce
Steps to reproduce the behavior:

1. Add mod IDs to GAME_MODS_IDS_LIST and start the server with mods
2. Remove IDs from GAME_MODS_IDS_LIST and update the stack
3. Game still starts with mods, because the mod IDs are still present in the server config

Expected behavior
I expect the server to start with no mods when GAME_MODS_IDS_LIST is empty

[sdsznsk]

https://github.com/acemod/docker-reforger#configs

Configs

By default the configs are generated from the ENV variables in the dockerfile. After the first run the file can be expanded with additional options manually, but the fields will always be overwritten by the ENV variables.

Alternatively, change the ARMA_CONFIG variable to a file present in the Configs volume. It will be used without modification.

This one is by design according to the readme (at least if I interpret it correctly).
Sure, I could change that but I will leave the decision to the folks if they actually want it.

[hafometh88]

I think the ENV vars should be the main source of truth. If people want to primarily modify the server config itself, there is the feature to change ARMA_CONFIG to a different config file.

[hafometh88]

I will leave the decision to the folks if they actually want it.

@sdsznsk So what do the folks say? :)

[hafometh88]

docker-reforger/launch.py

Lines 121 to 123 in 32a30c9

	if env_defined("GAME_MODS_IDS_LIST") or env_defined("GAME_MODS_JSON_FILE_PATH"):
	# Since we want to keep ENVs as a single source of truth
	# we will regenerate the mod list in case any manual changes were made