Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Turn list argument into repeatable flag #363

Open
iwilltry42 opened this issue Jul 28, 2022 · 3 comments
Open

Turn list argument into repeatable flag #363

iwilltry42 opened this issue Jul 28, 2022 · 3 comments
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@iwilltry42
Copy link
Contributor

Example argument:

args: {
  extra_food: ["hazelnut", "walnut"]
}

Expected usage:

acorn run . --extra-food foo --extra-food bar

Right now, all variants that I tried to pass in some sort of list (e.g. the one above, comma-separated, etc.) end up with an error similar to the one below:

acorn render . --extra-food foo --extra-food bar
Error: args.extra_food: 2 errors in empty disjunction:
args.extra_food: conflicting values "bar" and ["hazelnut","walnut"] (mismatched types string and list):
    /_internal_/args.cue:1:23
    Acornfile:2:15
args.extra_food: conflicting values "bar" and [...string] (mismatched types string and list):
    /_internal_/args.cue:1:23
    Acornfile:2:15
@iwilltry42 iwilltry42 added the kind/enhancement New feature or request label Jul 28, 2022
@cjellick cjellick added this to the v.Next milestone Aug 8, 2022
@iwilltry42 iwilltry42 self-assigned this Sep 25, 2022
@cjellick cjellick modified the milestones: v.Next, v0.3.0, v0.4.0 Sep 27, 2022
@cjellick cjellick changed the title Feat: Turn list argument into repeatable flag Turn list argument into repeatable flag Oct 5, 2022
@cjellick cjellick modified the milestones: v0.4.0, v0.4.1 Nov 17, 2022
@cjellick
Copy link
Member

not going to try to squeeze this into v0.4.1. bumping out to v0.5

@cjellick cjellick modified the milestones: v0.4.1, v0.5.0 Nov 22, 2022
@cjellick cjellick modified the milestones: v0.5.0, v.Next Dec 5, 2022
@cjellick cjellick modified the milestones: v.Next, Backlog Jan 28, 2023
@cjellick cjellick modified the milestones: Backlog, v0.6.0 Feb 13, 2023
@cjellick
Copy link
Member

Wonder if we can revisit this and get it out in v0.6.0. If you have a PR, it probably needs rebased pretty badly 😅

@cjellick
Copy link
Member

This is low priority, much lower than the signing and attestation, but I'm bringing it up in case you need/want a change of base occasionally while working on that feature.

@cjellick cjellick modified the milestones: v0.6.0, v.Next Feb 27, 2023
@cjellick cjellick modified the milestones: v.Next, Backlog Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants