Breadcrumb collapse #6892
Merged
Breadcrumb collapse #6892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/@react-spectrum/s2/src/Breadcrumbs.tsx # packages/@react-spectrum/s2/src/TagGroup.tsx
reidbarber
requested changes
Aug 22, 2024
LFDanLu
reviewed
Aug 28, 2024
snowystinger
commented
Aug 29, 2024
devongovett
reviewed
Aug 29, 2024
| <HiddenBreadcrumbs items={children} size={size} listRef={listRef} /> | ||
| {visibleItems < collection.size ? ( | ||
| <> | ||
| {children[0].render?.(children[0])} |
There was a problem hiding this comment.
Do we want to keep the showRoot option from v3?
There was a problem hiding this comment.
following up with spectrum
LFDanLu
reviewed
Aug 29, 2024
| {visibleItems < collection.size ? ( | ||
| <> | ||
| {children[0].render?.(children[0])} | ||
| <BreadcrumbMenu items={children.slice(1, sliceIndex)} onAction={onAction} /> |
There was a problem hiding this comment.
What if you only have two breadcrumbs? I assume it shouldn't show the breadcrumb menu still? It seems if you collapse it enough when there are only two items that the Breadcrumb menu shows up:
There was a problem hiding this comment.
fixed, see storybook from ac304c9 where i temporarily added some new stories to hit the edge cases
LFDanLu
previously approved these changes
Aug 29, 2024
reidbarber
previously approved these changes
Aug 29, 2024
Co-authored-by: Reid Barber <reid@reidbarber.com>
LFDanLu
approved these changes
Aug 29, 2024
ktabors
approved these changes
Aug 29, 2024
## API Changes
react-aria-components/react-aria-components:BreadcrumbRenderProps BreadcrumbRenderProps {
isCurrent: boolean
+ isDisabled: boolean
} |
reidbarber
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: