Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb collapse #6892

Merged
merged 26 commits into from
Aug 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
859b93d
Breadcrumb collapse
snowystinger Aug 16, 2024
75bc99a
use a custom renderer
snowystinger Aug 19, 2024
a621923
forward link props
snowystinger Aug 19, 2024
8950a4c
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 19, 2024
7978d78
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 20, 2024
f7326f6
don't need to specify branch
snowystinger Aug 20, 2024
068c3bb
measuring
snowystinger Aug 21, 2024
dacb2be
fix warnings and onAction
snowystinger Aug 21, 2024
05abcb3
more stories
snowystinger Aug 21, 2024
8f829f6
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 21, 2024
488e9fd
Fix our use of context in TagGroup
snowystinger Aug 21, 2024
14a48fe
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 21, 2024
b735798
Fix types
snowystinger Aug 22, 2024
9e16f3a
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 22, 2024
aaa99e6
Merge branch 'breadcrumb-menu' of github.com:adobe/react-spectrum int…
snowystinger Aug 22, 2024
fc19c58
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 27, 2024
e1d738d
fix TS
snowystinger Aug 27, 2024
2253530
fix taggroup
snowystinger Aug 28, 2024
a9b7ab2
review comments
snowystinger Aug 29, 2024
5869486
Fixed the TS error apparently
snowystinger Aug 29, 2024
16f5a5a
remove dead code
snowystinger Aug 29, 2024
647f75a
detect link out on menu item
snowystinger Aug 29, 2024
ac304c9
Fix bugs
snowystinger Aug 29, 2024
2988241
remove testing stories
snowystinger Aug 29, 2024
95c60c8
Merge branch 'main' into breadcrumb-menu
snowystinger Aug 29, 2024
96d3cb5
Update packages/@react-spectrum/s2/src/Breadcrumbs.tsx
snowystinger Aug 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forward link props
  • Loading branch information
snowystinger committed Aug 19, 2024
commit a621923d386f81f5d727731f6a0c232890bb79a3
7 changes: 7 additions & 0 deletions packages/@react-spectrum/s2/src/Breadcrumbs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ let BreadcrumbMenu = (props: BreadcrumbProps) => {
// pull off individual props as an allow list, don't want refs or other props getting through
return (
<MenuItem
href={item.props.href}
key={item.key}>
<Text slot="label">
{item.props.children({size, isInCtx: true, isCurrent: false, isMenu: true})}
Expand Down Expand Up @@ -293,6 +294,12 @@ function Breadcrumb({children, ...props}: BreadcrumbProps, ref: DOMRef<HTMLLIEle
<AriaBreadcrumb
{...other}
ref={domRef}
href={href}
target={target}
rel={rel}
download={download}
ping={ping}
referrerPolicy={referrerPolicy}
className={({isCurrent}) => breadcrumbStyles({size, isCurrent})}>
{({isCurrent, isDisabled, isMenu}) => {
if (isMenu) {
Expand Down