Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] MrSQM uses nested data frames #1685

Open
TonyBagnall opened this issue Jun 16, 2024 · 0 comments · May be fixed by #1735
Open

[ENH] MrSQM uses nested data frames #1685

TonyBagnall opened this issue Jun 16, 2024 · 0 comments · May be fixed by #1735
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Jun 16, 2024 •
edited
Loading

Describe the feature or idea you want to propose

MrSQM still uses

        "X_inner_type": "nested_univ",  # we don't like this, but it's the only input!

it would be really good if the original package switched to using numpy3D/np_list,

any thoughts @heerme, @Inthach @mbalatsko?

we would be happy to help. Failing that, I think we should internalise the conversion with a private local function, it must be the last usage
@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package labels Jun 16, 2024
@TonyBagnall TonyBagnall linked a pull request Jun 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] change input type for MrSQMClassifier aeon-toolkit/aeon
1 participant
@TonyBagnall