From 916dba066907c66aa2776af64b76638b08285207 Mon Sep 17 00:00:00 2001 From: subhod-i Date: Thu, 16 Jun 2022 14:08:02 +0530 Subject: [PATCH] fix(aepp): use networkId in rpc tx signing networkId is marked deprecated. using now to make sdk v12 aepps compatible with wallets using v11.0.1 and below. --- src/account/rpc.ts | 8 +++++++- tsdoc.json | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/account/rpc.ts b/src/account/rpc.ts index 67afa7d9d2..50b8231387 100644 --- a/src/account/rpc.ts +++ b/src/account/rpc.ts @@ -42,7 +42,13 @@ export default class AccountRpc extends AccountBase { const res = await this._rpcClient.request(METHODS.sign, { onAccount: this._address, tx, - returnSigned: true + returnSigned: true, + /** + * @deprecated Wallet provided networkId will be used (current network) + * required to maintain backward compatibility with wallets using SDK v11.0.1 and below + * @see {@link https://github.com/aeternity/aepp-sdk-js/commit/153fd89a52c4eab39fcd659b356b36d32129c1ba} + */ + networkId }) return res.signedTransaction } diff --git a/tsdoc.json b/tsdoc.json index b26de6ff7d..2b2c8256c3 100644 --- a/tsdoc.json +++ b/tsdoc.json @@ -11,6 +11,7 @@ "@link": true, "@see": true, "@example": true, - "@category": true + "@category": true, + "@deprecated": true } }